Comments
achow101
added a commit
to bitcoin-core/gui
that referenced
this issue
Jan 3, 2023
…error messages
76dc547 gui: create tx, launch error dialog if backend throws runtime_error (furszy)
f4d7947 wallet: coin selection, add duplicated inputs checks (furszy)
0aa065b wallet: return accurate error messages from Coin Selection (furszy)
7e8340a wallet: make SelectCoins flow return util::Result (furszy)
e5e147f wallet: refactor eight consecutive 'AttemptSelection' calls into a loop (furszy)
Pull request description:
Work decoupled from #25806, which cleanup and improves the Coin Selection flow further.
Adding the capability to propagate specific error messages from the Coin Selection process to the user.
Instead of always returning the general "Insufficient funds" message which is not always accurate to what happened internally.
Letting us instruct the user how to proceed under certain circumstances.
The following error messages were added:
1) If the selection result exceeds the maximum transaction weight,
we now will return:
-> "The inputs size exceeds the maximum weight. Please try sending
a smaller amount or manually consolidating your wallet's UTXOs".
2) If the user pre-selected inputs and disallowed the automatic coin
selection process (no other inputs are allowed), we now will
return:
-> "The preselected coins total amount does not cover the transaction
target. Please allow other inputs to be automatically selected or include
more coins manually".
3) The double-counted preset inputs during Coin Selection error will now
throw an "internal bug detected" message instead of crashing the node.
The essence of this work comes from several comments:
1. bitcoin/bitcoin#26560 (comment)
2. bitcoin/bitcoin#25729 (comment)
3. bitcoin/bitcoin#25269 (review)
4. bitcoin/bitcoin#23144 (which is connected to #24845)
ACKs for top commit:
ishaanam:
crACK 76dc547
achow101:
ACK 76dc547
aureleoules:
ACK 76dc547
theStack:
ACK 76dc547 🌇
Tree-SHA512: 9de30792d7a5849cae77747aa978e70390b66ee9d082779a56088a024f82e725b0af050e6603aece0ac8229f6d73bc471ba97b4ab69dc7eddf419f5f56ae89a5
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this issue
Jan 4, 2023
…ssages
76dc547 gui: create tx, launch error dialog if backend throws runtime_error (furszy)
f4d7947 wallet: coin selection, add duplicated inputs checks (furszy)
0aa065b wallet: return accurate error messages from Coin Selection (furszy)
7e8340a wallet: make SelectCoins flow return util::Result (furszy)
e5e147f wallet: refactor eight consecutive 'AttemptSelection' calls into a loop (furszy)
Pull request description:
Work decoupled from bitcoin#25806, which cleanup and improves the Coin Selection flow further.
Adding the capability to propagate specific error messages from the Coin Selection process to the user.
Instead of always returning the general "Insufficient funds" message which is not always accurate to what happened internally.
Letting us instruct the user how to proceed under certain circumstances.
The following error messages were added:
1) If the selection result exceeds the maximum transaction weight,
we now will return:
-> "The inputs size exceeds the maximum weight. Please try sending
a smaller amount or manually consolidating your wallet's UTXOs".
2) If the user pre-selected inputs and disallowed the automatic coin
selection process (no other inputs are allowed), we now will
return:
-> "The preselected coins total amount does not cover the transaction
target. Please allow other inputs to be automatically selected or include
more coins manually".
3) The double-counted preset inputs during Coin Selection error will now
throw an "internal bug detected" message instead of crashing the node.
The essence of this work comes from several comments:
1. bitcoin#26560 (comment)
2. bitcoin#25729 (comment)
3. bitcoin#25269 (review)
4. bitcoin#23144 (which is connected to bitcoin#24845)
ACKs for top commit:
ishaanam:
crACK 76dc547
achow101:
ACK 76dc547
aureleoules:
ACK 76dc547
theStack:
ACK 76dc547 🌇
Tree-SHA512: 9de30792d7a5849cae77747aa978e70390b66ee9d082779a56088a024f82e725b0af050e6603aece0ac8229f6d73bc471ba97b4ab69dc7eddf419f5f56ae89a5
1 час назад, Helber сказал:
что значит «доступен только для просмотра»? «Только чтение», или о чем вы?
То и значит. Так Электрум пишет, при входе в кошелек.
А если ты хочешь узнать, что такое «доступен только для просмотра» — то это значит, что в кошельке нет приватных ключей, отправка средств с кошелька невозможна без их наличия. Так бывает, когда новички загрузили адреса с большим балансом в Электрум и думают, что стали богачами.
Но это вроде не тот случай, тут говорят, что сид есть. Так делают, когда боятся кражи средств и вводят только xyzpub, чтобы только наблюдать за транзакциями. В эксплорере это делать морока, так как адресов может быть очень много.
1 час назад, spaga сказал:
12 слов есть, но почему то когда я в этом же кошелке создаю новый кошелек, нажимаю что у меня есть сид и ввожу его, то открывает пустой кошелек,
В Электруме есть три варианта формата адресов. Пустой кошелек на одном из форматов. Смотри второй и третий варианты. А вообще форматов еще больше.
Recommend Projects
-

ReactA declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-

TypescriptTypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlowAn Open Source Machine Learning Framework for Everyone
-
DjangoThe Web framework for perfectionists with deadlines.
-
LaravelA PHP framework for web artisans
-
D3Bring data to life with SVG, Canvas and HTML. 📊📈🎉
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
FacebookWe are working to build community through open source technology. NB: members must have two-factor auth.
-
MicrosoftOpen source projects and samples from Microsoft.
-
GoogleGoogle ❤️ Open Source for everyone.
-
AlibabaAlibaba Open Source for everyone
-
D3Data-Driven Documents codes.
-
TencentChina tencent open source team.
Jobs
Jooble